Skip to content

Fix eligibility typo#7236

Merged
erich-wang merged 2 commits intoAzure:masterfrom
tezhangmsvan:master
Sep 19, 2019
Merged

Fix eligibility typo#7236
erich-wang merged 2 commits intoAzure:masterfrom
tezhangmsvan:master

Conversation

@tezhangmsvan
Copy link
Copy Markdown
Contributor

@tezhangmsvan tezhangmsvan commented Sep 17, 2019 •
edited by hitenjava
Loading

Bug #4678

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Sep 17, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from f8a0f9f, Iteration 3)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 17, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7323

@AutorestCI AutorestCI mentioned this pull request Sep 17, 2019
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 17, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5826

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 17, 2019

Can one of the admins verify this patch?

@erich-wang erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 18, 2019
KrisBash
KrisBash approved these changes Sep 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off for ARM with the assumption that this is a bug fix in swagger. If the server is returning the property with the wrong spelling, it'd be better to change in a new api version update. This is a preview API, but property removal is considered breaking.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2019
@nschonni
Copy link
Copy Markdown
Contributor

nschonni commented Sep 18, 2019

You can remove the suppression if you're fixing them

azure-rest-api-specs/cSpell.json

Lines 248 to 253 in 7685f61

{
"filename": "**/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-03-31-preview/definitions/TasksCommon.json",
"words": [
"Eligibile"
]
},

azure-rest-api-specs/cSpell.json

Line 195 in 7685f61

"Eligibile",

azure-rest-api-specs/cSpell.json

Lines 254 to 259 in 7685f61

{
"filename": "**/specification/datamigration/resource-manager/Microsoft.DataMigration/stable/2018-04-19/definitions/TasksCommon.json",
"words": [
"Eligibile"
]
},

@tezhangmsvan
Copy link
Copy Markdown
Contributor Author

tezhangmsvan commented Sep 18, 2019

Added commit to remove suppression. Thanks

This was referenced Sep 19, 2019
Merged
Closed
@erich-wang erich-wang merged commit faf99f5 into Azure:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hitenjava hitenjava hitenjava approved these changes

@binuj binuj Awaiting requested review from binuj

@huang91shu huang91shu Awaiting requested review from huang91shu

@erich-wang erich-wang Awaiting requested review from erich-wang

+1 more reviewer

@KrisBash KrisBash KrisBash approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erich-wang erich-wang

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tezhangmsvan @AutorestCI @azuresdkci @nschonni @KrisBash @hitenjava @erich-wang @tezhangtiger